-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc: Move target libraries to lib
output when building a cross compiler
#81781
Conversation
…uts to lib when it is set
@illegalprime this pulls in stuff from your PR #58606. Do you mind if I take over since the last commit to that PR was April of last year?? I'll make sure you're still credited with authorship in the git commits. @lopsided98 you had an alternate way of fixing this, right? Does it work for armv7l and across gcc versions too? If so maybe we should compare these approaches and pick one to advocate for merging. |
@flokli cc |
I'm currently testing my version on armv7l. I don't know of any reason it wouldn't work on other gcc versions, but I haven't tested yet. |
@lopsided98 can you publish it as a branch? I'd love to try it out too. |
I successfully built |
@lopsided98 how does your branch differ from the changes proposed here? Can you elaborate? |
The functional difference is that the libraries are placed in |
Closing in favor of #81844 |
Great. Glad this is fixed :) |
Motivation for this change
Programs and libraries cross-compiled with nixpkgs gcc often had the entire gcc store path in their closure, since gcc's target libraries wound up in the main store output. See #58501
Things done
Adjust
pkgs/development/compilers/gcc/builder.sh
to put target system libraries in thelib
output.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)